Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add policy check summary in wrapped messages #2452

Merged
merged 2 commits into from
Nov 13, 2022
Merged

Add policy check summary in wrapped messages #2452

merged 2 commits into from
Nov 13, 2022

Conversation

tlorreyte
Copy link
Contributor

Closes #2349

Currently the only way to get a summary of the Conftest output (ie the last line) is to expand the comment.

When the security check comment is very long, it could be annoying to scroll down until find the summary line (v tests, w passed, x warnings, y failures, z exceptions).

Like the Terraform plan output, it might be interesting to have the summary of the Conftest result in the reduced comment

It's just an addition to the templating of the security checks collapsed message.
I don't think there is any need for error handling on the message regex.

@tlorreyte tlorreyte requested a review from a team as a code owner August 16, 2022 09:23
@jamengual jamengual added the waiting-on-review Waiting for a review from a maintainer label Aug 18, 2022
@nitrocode
Copy link
Member

cc: @jamengual

@nitrocode nitrocode merged commit 7f75002 into runatlantis:master Nov 13, 2022
@nitrocode
Copy link
Member

Thank you @tlorreyte for the contribution!

@DanielCastronovo DanielCastronovo mentioned this pull request Dec 6, 2022
Closed
krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
@tlorreyte @nitrocode @krrrr38
feat: add policy check summary in wrapped messages (runatlantis#2452)
59efde7 
Co-authored-by: nitrocode <[email protected]>
@krrrr38 krrrr38 mentioned this pull request Dec 20, 2022
Merged
@nitrocode nitrocode added this to the 0.21.0 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

@nitrocode nitrocode nitrocode approved these changes

Assignees
No one assigned
Labels
waiting-on-review Waiting for a review from a maintainer
Projects
None yet
Milestone
v0.21.0
Development

Successfully merging this pull request may close these issues.

Feature proposal : Add information in the collapsed security check comment
3 participants
@tlorreyte @nitrocode @jamengual